Skip to content

Upgrade to vsc 1.49 and fix nyc compile error#14455

Closed
joyceerhl wants to merge 4 commits intomainfrom
fix-nyc-compiler-error
Closed

Upgrade to vsc 1.49 and fix nyc compile error#14455
joyceerhl wants to merge 4 commits intomainfrom
fix-nyc-compiler-error

Conversation

@joyceerhl
Copy link
Copy Markdown

@joyceerhl joyceerhl commented Oct 20, 2020

#14406 introduced a nyc compiler error resulting from importing two proposed API interfaces from 'vscode' instead of 'vscode.proposed.d.ts'. Additionally, the proposed API for contributing to the debug context menu was introduced in https://code.visualstudio.com/updates/v1_49#_contributable-context-menu-for-variables-view.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Oct 20, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 20, 2020 •
edited
Loading

Codecov Report

Merging #14455 into main will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14455      +/-   ##
==========================================
- Coverage   59.19%   59.17%   -0.02%     
==========================================
  Files         720      720              
  Lines       40211    40247      +36     
  Branches     5829     5834       +5     
==========================================
+ Hits        23802    23818      +16     
- Misses      15147    15167      +20     
  Partials     1262     1262
Impacted Files Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts 100.00% <ø> (ø)
.../pythonEnvironments/info/environmentInfoService.ts 93.61% <0.00%> (-6.39%) ⬇️
src/client/pythonEnvironments/index.ts 18.05% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20349f2...23f5e0c. Read the comment docs.

DonJayamanne
DonJayamanne reviewed Oct 20, 2020
View reviewed changes
package.json
},
"engines": {
"vscode": "^1.48.0"
"vscode": "^1.49.0"
Copy link
Copy Markdown

@DonJayamanne DonJayamanne Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 1.50

Copy link
Copy Markdown
Author

@joyceerhl joyceerhl Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonJayamanne, I just saw this. I only wanted to bump to the minimum required, which in the case of the debug context menu contribution point is 1.49. Otherwise we're forcing users to upgrade when the extension really doesn't require it

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joyceerhl
Copy link
Copy Markdown
Author

joyceerhl commented Oct 21, 2020

Doing this in #14460 due to #14460 (comment)

@joyceerhl joyceerhl closed this Oct 21, 2020
@kimadeline kimadeline mentioned this pull request Oct 21, 2020
Closed
@joyceerhl joyceerhl deleted the fix-nyc-compiler-error branch October 26, 2020 16:31
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59%. Comparing base (20349f2) to head (23f5e0c).
⚠️ Report is 2824 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff           @@
##            main   #14455   +/-   ##
======================================
- Coverage     59%      59%   -1%     
======================================
  Files        720      720           
  Lines      40211    40247   +36     
  Branches    5829     5834    +5     
======================================
+ Hits       23802    23818   +16     
- Misses     15147    15167   +20     
  Partials    1262     1262
Files with missing lines Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts 100% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonJayamanne DonJayamanne DonJayamanne left review comments

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyceerhl @codecov-io @codecov-commenter @IanMatthewHuff @DonJayamanne @rchiodo